Fixed OpenBSD node executable generation.#22663
Closed
sylkat wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
Fixed OpenBSD node executable generation.#22663sylkat wants to merge 1 commit intonodejs:v8.x-stagingfrom
sylkat wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
nodejs-github-bot
added
lib / src
Member
addaleax
added
the
author ready
Member
|
Failures seem unrelated, resume CI: https://ci.nodejs.org/job/node-test-pull-request/16984/ |
Contributor
|
BSD failure is a known flake |
Contributor
|
Can't check the windows failure due to 504 errors. Will check back soon. Would very much like to get this in the 8.12.0 release tomorrow as this is a fairly obvious error. Should be backported to v6.x as well. |
Member
|
@MylesBorins I would be okay with landing this without regard to the outcome of the CI runs, since this code path is never actually exercised by our CI. |
Contributor
|
landed in d478bc7 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 3, 2018
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 3, 2018
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Author
|
I think the failures in other system compilation have nothing to do with this patch since the code check for openbsd host before call that method.. |
rvagg
pushed a commit
that referenced
this pull request
Nov 24, 2018
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Mar 7, 2019
Currently makes a call to `realpathSync.native` which doesn't exist on 8.x or lower PR-URL: #22663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the realpathSync object calling to the 'native' method which doesn't exist in this version of FS module.
Just removing that method is working well in OpenBSD.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes